Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unwrap undefined tensor #56

Open
wants to merge 1 commit into
base: 9-9
Choose a base branch
from
Open

Conversation

MarisaKirisame
Copy link
Collaborator

This PR unwrap undefined tensor when interfacing with the rest of the pytorch system.
This is because undefined is handle specially in other places.
For example, in autograd, a undefined value will get ignored, but a checkpointed-undefined value will try to be process by the system, leading to an error (because there is nothing to back propagate against).
This happen when you try to do a second order gradient over convolution2d, because conv2d return undefined for values when it dont need to to save time.

There is also some minor fixes that made us play better with autograd. pytorch has weird and poorly documented semantic regarding requrires_grad and dispatch key that I didnt got right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant